Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Extend observer Access API integration tests for local data #5612

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #5573

In this PR was created a test that covers each of the endpoints for the observer, and verifies that the data returned is the expected value.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (ad12394) to head (0b9e68a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5612      +/-   ##
==========================================
+ Coverage   55.55%   55.57%   +0.01%     
==========================================
  Files        1043     1043              
  Lines      102034   102029       -5     
==========================================
+ Hits        56689    56706      +17     
+ Misses      40992    40970      -22     
  Partials     4353     4353              
Flag Coverage Δ
unittests 55.57% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Guitarheroua Guitarheroua self-requested a review April 2, 2024 12:30
@AndriiDiachuk AndriiDiachuk marked this pull request as ready for review April 2, 2024 13:56
access/handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@peterargue peterargue added this pull request to the merge queue Apr 9, 2024
Merged via the queue into onflow:master with commit b92fe5d Apr 9, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Extend observer Access API integration tests for local data
4 participants