Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade onflow/crypto and clarify build details #5601

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Mar 28, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.66%. Comparing base (51a3fb6) to head (7c4af2d).
Report is 113 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5601      +/-   ##
==========================================
- Coverage   55.67%   55.66%   -0.02%     
==========================================
  Files        1037     1041       +4     
  Lines      101404   101935     +531     
==========================================
+ Hits        56457    56742     +285     
- Misses      40607    40840     +233     
- Partials     4340     4353      +13     
Flag Coverage Δ
unittests 55.66% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby marked this pull request as ready for review March 29, 2024 04:14
@tarakby tarakby requested review from turbolent and jribbink March 29, 2024 20:25
@tarakby tarakby changed the title Clarify build details when importing the module Upgrade crypto and clarify build details Apr 3, 2024
@tarakby tarakby changed the title Upgrade crypto and clarify build details Upgrade onflow/crypto and clarify build details Apr 3, 2024
@tarakby tarakby added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit 1aab1ef Apr 3, 2024
55 checks passed
@tarakby tarakby deleted the tarak/crypto-build branch April 3, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants