Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax requirement for elapsed time during binstat init #5589

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

jribbink
Copy link
Contributor

closes #5584

Relaxes the requirement for elapsed time because some systems do not have time resolution precise enough in comparison to the execution time.

@jribbink jribbink enabled auto-merge March 26, 2024 17:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.50%. Comparing base (d89c1c3) to head (15c89f0).

Files Patch % Lines
utils/binstat/binstat.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5589      +/-   ##
==========================================
- Coverage   57.34%   55.50%   -1.84%     
==========================================
  Files         930      950      +20     
  Lines       90291    94127    +3836     
==========================================
+ Hits        51775    52248     +473     
- Misses      34461    37861    +3400     
+ Partials     4055     4018      -37     
Flag Coverage Δ
unittests 55.50% <0.00%> (-1.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@jribbink jribbink added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit f5d8ff9 Mar 26, 2024
55 checks passed
@jribbink jribbink deleted the jribbink/binstat-time-elapse branch March 26, 2024 19:49
jribbink added a commit that referenced this pull request Apr 5, 2024
Relax requirement for elapsed time during binstat init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binstat error panic: ERROR: BINSTAT: INTERNAL: t1=90173378966800 but t2=90173378966800
4 participants