Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Fix event conversion in local TxResults endpoint #5582

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

peterargue
Copy link
Contributor

When running an AN configured to use local events for tx results, the event conversion was thrown away. This was caused by updating a local variable reference within a loop instead of the original data.

@peterargue peterargue requested a review from Guitarheroua March 25, 2024 20:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 57.04%. Comparing base (5e65e12) to head (2d9d4b5).

Files Patch % Lines
engine/common/rpc/convert/events.go 0.00% 10 Missing ⚠️
...ss/rpc/backend/transactions_local_data_provider.go 33.33% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5582      +/-   ##
==========================================
+ Coverage   55.64%   57.04%   +1.39%     
==========================================
  Files        1037      872     -165     
  Lines      101338    86800   -14538     
==========================================
- Hits        56393    49514    -6879     
+ Misses      40605    33428    -7177     
+ Partials     4340     3858     -482     
Flag Coverage Δ
unittests 57.04% <15.78%> (+1.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue requested a review from zhangchiqing March 25, 2024 21:26
@peterargue peterargue added this pull request to the merge queue Mar 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2024
@peterargue peterargue added this pull request to the merge queue Mar 26, 2024
Merged via the queue into master with commit d89c1c3 Mar 26, 2024
55 checks passed
@peterargue peterargue deleted the petera/backport-tx-results-fix branch March 26, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants