[Flow EVM] Adding FLOW token bridge event #5538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5538 +/- ##
==========================================
+ Coverage 55.62% 55.64% +0.02%
==========================================
Files 1037 1037
Lines 101338 101338
==========================================
+ Hits 56369 56394 +25
+ Misses 40630 40605 -25
Partials 4339 4339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fvm/evm/stdlib/contract.cdc
Outdated
| @@ -7,6 +7,18 @@ contract EVM { | |||
| access(all) | |||
| event CadenceOwnedAccountCreated(addressBytes: [UInt8; 20]) | |||
|
|
|||
| /// FLOWTokenDeposit is emitted when FLOW tokens is bridged | |||
There was a problem hiding this comment.
I think we are using past tense for events. FLOWTokensDeposited.
There was a problem hiding this comment.
Update those to use past participle.
fvm/evm/stdlib/contract.cdc
Outdated
| @@ -224,6 +238,7 @@ contract EVM { | |||
| from: self.addressBytes, | |||
| amount: balance.attoflow | |||
| ) as! @FlowToken.Vault | |||
| emit FLOWTokenWithdraw(addressBytes: self.addressBytes, amount: balance.inFLOW()) | |||
There was a problem hiding this comment.
I would not emit an event if the balance is 0. I think I would prefer the whole function just exiting early if the balance is 0.
same with deposit.
janezpodhostnik
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5537