Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] make EVM address' code/codeHash/nonce accessible #5460

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

ramtinms
Copy link
Contributor

closes: #5458

@ramtinms ramtinms marked this pull request as ready for review February 26, 2024 21:44
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (c912767) to head (f9c5cbf).

Files Patch % Lines
fvm/evm/stdlib/contract.go 84.00% 6 Missing and 6 partials ⚠️
fvm/evm/handler/handler.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
- Coverage   56.04%   56.03%   -0.01%     
==========================================
  Files        1026     1010      -16     
  Lines      100038    98886    -1152     
==========================================
- Hits        56064    55415     -649     
+ Misses      39685    39208     -477     
+ Partials     4289     4263      -26     
Flag Coverage Δ
unittests 56.03% <79.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


/// Code of the address
access(all)
fun code(): [UInt8] {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ramtinms ramtinms added this pull request to the merge queue Feb 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 27, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 6908b7e Feb 27, 2024
50 of 51 checks passed
@ramtinms ramtinms deleted the ramtin/5458-expose-evm-code-codehash-nonce branch February 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] expose code/codeHash and nonce for the EVM account
4 participants