Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v1.0.0-M8 #5442

Merged

Conversation

turbolent
Copy link
Member

Description

Automatically update to:

@turbolent turbolent requested review from a team February 22, 2024 20:49
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.72%. Comparing base (607d0fe) to head (63c929a).
Report is 3 commits behind head on feature/stable-cadence.

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5442      +/-   ##
==========================================================
- Coverage                   56.31%   54.72%   -1.60%     
==========================================================
  Files                        1030      921     -109     
  Lines                      100049    87569   -12480     
==========================================================
- Hits                        56347    47923    -8424     
+ Misses                      39439    35921    -3518     
+ Partials                     4263     3725     -538     
Flag Coverage Δ
unittests 54.72% <100.00%> (-1.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member Author

turbolent commented Feb 22, 2024

@SupunS To unblock updating downstream dependencies, I'm going to merge this for now, as the state migration is only used in flow-go itself, and not in any of the downstream dependencies.

Could you please have a look at and fix up the invocation of NewCadenceV042ToV1ContractUpdateValidator in a follow up PR? see https://github.com/onflow/flow-go/pull/5442/files#diff-21e3bd4ff5c152211427ad3ebc982745163a76a94c80071d0f8705374663699bR245-R252, i.e. the changes of 63c929a

  • I didn't know why the location wasn't passed before. I guess it didn't matter / wasn't used yet? Can you please check if passing location there is correct?
  • I provided the argument for the new provider AccountContractNamesProvider parameter by using the environment that was already used for AccountContractAdditionHandler. Could you please check this is correct or fix it if not?
  • I didn't know where to get the argument for the new newElaborations map[common.Location]*sema.Elaboration parameter from, and left a TODO

@turbolent turbolent merged commit 3677206 into feature/stable-cadence Feb 22, 2024
50 of 51 checks passed
@turbolent turbolent deleted the auto-update-onflow-cadence-v1.0.0-M8 branch February 22, 2024 21:35
@SupunS
Copy link
Member

SupunS commented Feb 23, 2024

Cross-posting the offline sync for any future reference:

I had fixed both 1 and 2 (location and elaborations passing) in a follow-up PR: #5405. Location should've been passed, but yeah, it didn't needed previously.

I provided the argument for the new provider AccountContractNamesProvider parameter by using the environment that was already used for AccountContractAdditionHandler. Could you please check this is correct or fix it if not?

Looks good! Thanks for updating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants