[Flow EVM] Add test for tx with zero fee or dynamic fees #5432
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
==========================================
- Coverage 56.00% 55.48% -0.53%
==========================================
Files 1024 1000 -24
Lines 99327 96203 -3124
==========================================
- Hits 55632 53380 -2252
+ Misses 39455 38754 -701
+ Partials 4240 4069 -171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fvm/evm/emulator/config.go
Outdated
| @@ -87,7 +87,7 @@ func defaultConfig() *Config { | |||
| CanTransfer: gethCore.CanTransfer, | |||
| Transfer: gethCore.Transfer, | |||
| GasLimit: BlockLevelGasLimit, | |||
| BaseFee: big.NewInt(0), | |||
There was a problem hiding this comment.
It seems the underlying code is dependent on nil than zero.
There was a problem hiding this comment.
I just hate go-ethereum for this kind of stuff, I just spent yesterday too much time on realising that I need to return a nil value for something to work, albeit being an anti-pattern in go, since you need to return an error in that case.
There was a problem hiding this comment.
we endup not needing this, so this PR just adds more tests :D
|
I will try to test this in the emulator later today and if it works I would say this would be a nice thing to have deployed on previewnet. Further more I would make this a config option of the EVM. Maybe the latter is a request for change. |
This PR adds some tests for the emulator for transactions with gas fees of zero or dynamic fees.