Add Windows support when compiling with CGO_ENABLED #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5430 +/- ##
==========================================================
- Coverage 56.37% 56.35% -0.02%
==========================================================
Files 1030 1030
Lines 99869 99869
==========================================================
- Hits 56300 56284 -16
- Misses 39311 39323 +12
- Partials 4258 4262 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tarakby
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Nice!
Was this PR added to address this question or was it a coincidence?
franklywatson
approved these changes
Feb 21, 2024
|
@tarakby Purely a coincidence 😀 |
6 tasks
jribbink
pushed a commit
that referenced
this pull request
Mar 6, 2024
Add Windows support when compiling with CGO_ENABLED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Windows support to binstat.go
gettidutility