Add more test assertions for EVM events #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0e81fd to
bd72a51
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5416 +/- ##
==========================================
+ Coverage 55.98% 57.51% +1.52%
==========================================
Files 1026 856 -170
Lines 99902 85152 -14750
==========================================
- Hits 55930 48973 -6957
+ Misses 39677 32364 -7313
+ Partials 4295 3815 -480
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
48ffcdd to
1f1e53a
Compare
1f1e53a to
b831b03
Compare
ramtinms
reviewed
Feb 22, 2024
| @@ -143,7 +143,7 @@ func (p *TransactionExecutedPayload) CadenceEvent() (cadence.Event, error) { | |||
| cadence.String(p.Result.VMErrorString()), | |||
| cadence.NewUInt8(p.Result.TxType), | |||
| cadence.NewUInt64(p.Result.GasConsumed), | |||
| cadence.String(hex.EncodeToString(p.Result.DeployedContractAddress.Bytes())), | |||
There was a problem hiding this comment.
is this for 0x prefixing?
There was a problem hiding this comment.
Not only for that. The format changes:
from: 99466ed2e37b892a2ee3e9cd55a98b68f5735db2
to: 0x99466ED2E37B892A2Ee3E9CD55a98b68f5735db2
which is the preferred check-summed variant.
ramtinms
approved these changes
Feb 22, 2024
janezpodhostnik
approved these changes
Feb 23, 2024
|
@m-Peter can we merge this one ? |
|
@ramtinms Yes, this is good to go I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also changed the format of
evm.TransactionExecuted.DeployedContractAddress:from:
99466ed2e37b892a2ee3e9cd55a98b68f5735db2to:
0x99466ED2E37B892A2Ee3E9CD55a98b68f5735db2which is the preferred check-summed variant.