Add checkpoint size metrics #5395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5395 +/- ##
==========================================
- Coverage 55.97% 55.91% -0.06%
==========================================
Files 1023 1016 -7
Lines 98930 98246 -684
==========================================
- Hits 55380 54939 -441
+ Misses 39349 39136 -213
+ Partials 4201 4171 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
approved these changes
Feb 15, 2024
| @@ -22,6 +22,7 @@ type ExecutionCollector struct { | |||
| lastFinalizedExecutedBlockHeightGauge prometheus.Gauge | |||
| stateStorageDiskTotal prometheus.Gauge | |||
| storageStateCommitment prometheus.Gauge | |||
| checkpointSize prometheus.Gauge | |||
There was a problem hiding this comment.
Does this need an initialisation?
There was a problem hiding this comment.
yes, I think it will panic if it's not initialized
| @@ -650,6 +651,7 @@ func NewExecutionCollector(tracer module.Tracer) *ExecutionCollector { | |||
| Help: "the execution state size on disk in bytes", | |||
| }), | |||
|
|
|||
| // TODO: remove | |||
There was a problem hiding this comment.
Is this todo for another PR? If so, maybe add more context.
peterargue
reviewed
Feb 15, 2024
| @@ -22,6 +22,7 @@ type ExecutionCollector struct { | |||
| lastFinalizedExecutedBlockHeightGauge prometheus.Gauge | |||
| stateStorageDiskTotal prometheus.Gauge | |||
| storageStateCommitment prometheus.Gauge | |||
| checkpointSize prometheus.Gauge | |||
There was a problem hiding this comment.
yes, I think it will panic if it's not initialized
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com> Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
peterargue
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5392