Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] rename bridged accounts to COAs #5381

Merged
merged 7 commits into from
Feb 17, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Feb 13, 2024

closes: #5380

@ramtinms ramtinms marked this pull request as ready for review February 13, 2024 18:16
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please also update the FLIP accordingly

Base automatically changed from ramtin/5225-returning-error to master February 16, 2024 23:02
@ramtinms ramtinms enabled auto-merge February 16, 2024 23:03
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b579900) 58.41% compared to head (de4a549) 55.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5381      +/-   ##
==========================================
- Coverage   58.41%   55.98%   -2.43%     
==========================================
  Files         981     1024      +43     
  Lines       93486    99160    +5674     
==========================================
+ Hits        54608    55513     +905     
- Misses      34675    39408    +4733     
- Partials     4203     4239      +36     
Flag Coverage Δ
unittests 55.98% <100.00%> (-2.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@ramtinms ramtinms enabled auto-merge February 17, 2024 02:58
@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@turbolent
Copy link
Member

Adjusted BridgedAccountContract in b668ba7

@turbolent turbolent enabled auto-merge February 17, 2024 21:14
@turbolent turbolent added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@turbolent turbolent merged commit 6976a4d into master Feb 17, 2024
51 checks passed
@turbolent turbolent deleted the ramtin/5380-rename-bridge-account branch February 17, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] rename all reference of bridged account to COA
5 participants