-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor doc update for Chunk Data Pack #5378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexHentschel
requested review from
zhangchiqing,
durkmurder and
janezpodhostnik
February 13, 2024 02:28
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5378 +/- ##
==========================================
- Coverage 55.88% 55.83% -0.05%
==========================================
Files 1024 1029 +5
Lines 99160 100783 +1623
==========================================
+ Hits 55411 56272 +861
- Misses 39511 40177 +666
- Partials 4238 4334 +96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
approved these changes
Feb 13, 2024
janezpodhostnik
approved these changes
Feb 13, 2024
zhangchiqing
approved these changes
Feb 13, 2024
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
all suggestions applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extending the documentation to be clear that State Proofs need to include all touched registers (read and written)