Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor doc update for Chunk Data Pack #5378

Merged
merged 5 commits into from
Mar 4, 2024
Merged

minor doc update for Chunk Data Pack #5378

merged 5 commits into from
Mar 4, 2024

Conversation

AlexHentschel
Copy link
Member

@AlexHentschel AlexHentschel commented Feb 13, 2024

extending the documentation to be clear that State Proofs need to include all touched registers (read and written)

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.83%. Comparing base (8fe638a) to head (a0fff1a).
Report is 464 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5378      +/-   ##
==========================================
- Coverage   55.88%   55.83%   -0.05%     
==========================================
  Files        1024     1029       +5     
  Lines       99160   100783    +1623     
==========================================
+ Hits        55411    56272     +861     
- Misses      39511    40177     +666     
- Partials     4238     4334      +96     
Flag Coverage Δ
unittests 55.83% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

model/flow/chunk.go Outdated Show resolved Hide resolved
model/flow/chunk.go Show resolved Hide resolved
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
@AlexHentschel
Copy link
Member Author

all suggestions applied

@AlexHentschel AlexHentschel added this pull request to the merge queue Mar 4, 2024
Merged via the queue into master with commit fe2ffc7 Mar 4, 2024
51 checks passed
@AlexHentschel AlexHentschel deleted the alex/cdp_doc branch March 4, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants