-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Fixed public network execution data service component #5375
[Access] Fixed public network execution data service component #5375
Conversation
what issue did you see with the existing code? Can you add a test to catch it? |
I added " |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5375 +/- ##
==========================================
- Coverage 55.95% 55.76% -0.20%
==========================================
Files 1023 1012 -11
Lines 98930 98219 -711
==========================================
- Hits 55356 54770 -586
+ Misses 39368 39268 -100
+ Partials 4206 4181 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I don't see this change in your PR? Can you add a test validating that execution sync works as expected between an AN/ON with this setting is enabled? for instance, you could create an ON version of |
This bug also affects the automated load testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
Issue
The current state of the ANs contains an issue related to the creation of the
"public network execution data service"
component.Error:
panic: component may only be started once
Context
This pull request addresses the problem by implementing necessary fixes to the component creation process.