Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Fixed public network execution data service component #5375

Conversation

UlyanaAndrukhiv
Copy link
Contributor

@UlyanaAndrukhiv UlyanaAndrukhiv commented Feb 12, 2024

Issue

The current state of the ANs contains an issue related to the creation of the "public network execution data service" component.
Error: panic: component may only be started once

Context

This pull request addresses the problem by implementing necessary fixes to the component creation process.

@peterargue
Copy link
Contributor

what issue did you see with the existing code? Can you add a test to catch it?

@UlyanaAndrukhiv
Copy link
Contributor Author

what issue did you see with the existing code? Can you add a test to catch it?

I added "public-network-execution-data-sync-enabled" flag to integration test to catch it and I see panic: component may only be started once error for public network execution data service component. It happens cause RegisterBlobService already starts the component, see here

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae8ab05) 55.95% compared to head (6cabb8a) 55.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5375      +/-   ##
==========================================
- Coverage   55.95%   55.76%   -0.20%     
==========================================
  Files        1023     1012      -11     
  Lines       98930    98219     -711     
==========================================
- Hits        55356    54770     -586     
+ Misses      39368    39268     -100     
+ Partials     4206     4181      -25     
Flag Coverage Δ
unittests 55.76% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue
Copy link
Contributor

I added "public-network-execution-data-sync-enabled" flag to integration test to catch it

I don't see this change in your PR? Can you add a test validating that execution sync works as expected between an AN/ON with this setting is enabled? for instance, you could create an ON version of execution_state_sync_test.go or extend it to include observers as well

@janezpodhostnik
Copy link
Contributor

This bug also affects the automated load testing.
The access note fails on startup due to "component may only be started once".
I have confirmed its related to "-public-network-execution-data-sync-enabled=true". If i disable it everything works as expected.

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@peterargue peterargue added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@peterargue peterargue added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@peterargue peterargue added this pull request to the merge queue Feb 16, 2024
Merged via the queue into onflow:master with commit db3d671 Feb 16, 2024
51 checks passed
zhangchiqing added a commit that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants