Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR 5254 #5359

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Backport PR 5254 #5359

merged 3 commits into from
Feb 7, 2024

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Feb 7, 2024

Backport #5254 into v0.33

⚠️ Will wait for:

  • the Cadence changes to be merged
  • the HCU version to be tagged as v0.33.7

Only then this PR can be opened and merged.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (204a1a2) 57.51% compared to head (708524b) 55.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.33    #5359      +/-   ##
==========================================
- Coverage   57.51%   55.51%   -2.01%     
==========================================
  Files         814      995     +181     
  Lines       77831    95723   +17892     
==========================================
+ Hits        44763    53137    +8374     
- Misses      29666    38608    +8942     
- Partials     3402     3978     +576     
Flag Coverage Δ
unittests 55.51% <ø> (-2.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby marked this pull request as ready for review February 7, 2024 17:41
@tarakby tarakby requested a review from ramtinms as a code owner February 7, 2024 17:41
@tarakby tarakby merged commit bf54231 into v0.33 Feb 7, 2024
50 of 51 checks passed
@tarakby tarakby deleted the tarak/new-cd-images-v0.33 branch February 7, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants