Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] COA ownership proof - part 2 #5342

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Feb 1, 2024

This PR updates the cadence arch precompile to accept COA ownership proofs for verification.

@ramtinms ramtinms marked this pull request as ready for review February 1, 2024 23:15
fvm/evm/precompiles/abi.go Outdated Show resolved Hide resolved
fvm/evm/precompiles/abi.go Outdated Show resolved Hide resolved
fvm/evm/precompiles/abi.go Outdated Show resolved Hide resolved
fvm/evm/precompiles/abi.go Show resolved Hide resolved
fvm/evm/precompiles/abi_test.go Show resolved Hide resolved
fvm/evm/precompiles/arch.go Outdated Show resolved Hide resolved
@@ -0,0 +1,92 @@
package precompiles_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change the package name? why I'm asking because if not it seems we could keep encode/decode functions unexported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want people to use these methods yet, maybe we move them into abi package in the future.

@sideninja sideninja self-requested a review February 8, 2024 13:42
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but looks good in general.

Base automatically changed from ramtin/5197-part1-expose-invoke to master February 8, 2024 17:34
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Attention: 1276 lines in your changes are missing coverage. Please review.

Comparison is base (cafb1a6) 56.02% compared to head (79b5462) 55.96%.
Report is 3249 commits behind head on master.

Files Patch % Lines
...util/ledger/migrations/cadence_value_validation.go 43.62% 172 Missing and 27 partials ⚠️
...edger/migrations/change_contract_code_migration.go 27.90% 184 Missing and 2 partials ⚠️
...md/util/ledger/util/migration_runtime_interface.go 0.00% 150 Missing ⚠️
...util/ledger/migrations/atree_register_migration.go 52.10% 104 Missing and 21 partials ⚠️
cmd/execution_builder.go 0.00% 116 Missing ⚠️
...d/util/ledger/migrations/storage_used_migration.go 2.40% 81 Missing ⚠️
cmd/util/ledger/util/util.go 0.00% 79 Missing ⚠️
.../util/ledger/migrations/account_based_migration.go 70.53% 50 Missing and 11 partials ⚠️
cmd/scaffold.go 0.00% 38 Missing ⚠️
consensus/hotstuff/committees/static.go 0.00% 37 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5342      +/-   ##
==========================================
- Coverage   56.02%   55.96%   -0.07%     
==========================================
  Files         965     1023      +58     
  Lines       89671    98820    +9149     
==========================================
+ Hits        50241    55302    +5061     
- Misses      35678    39353    +3675     
- Partials     3752     4165     +413     
Flag Coverage Δ
unittests 55.96% <43.43%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly reviewed the Cadence-related code, which looks good 👍

Comment on lines +11 to +16
// This package provides fast and efficient
// utilities needed for abi encoding and decoding
// encodings are mostly used for testing purpose
// if more complex encoding and decoding is needed please
// use the abi package and pass the ABIs, though
// that has a performance overhead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move up, just above the package declaration

@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2024
@ramtinms ramtinms added this pull request to the merge queue Feb 12, 2024
Merged via the queue into master with commit 1baa345 Feb 12, 2024
51 checks passed
@ramtinms ramtinms deleted the ramtin/5197-part2-precompile branch February 12, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants