Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Refactor access connection cache #5334

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

peterargue
Copy link
Contributor

Closes: #5074
Closes: #5087

This PR addresses 2 issues related to Access connection caching by refactoring the Cache and CachedClient structs to consolidate the cache creating and invalidation logic.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8b2113a) 55.96% compared to head (cf4b8fd) 55.97%.

Files Patch % Lines
engine/access/rpc/connection/cache.go 93.05% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5334    +/-   ##
========================================
  Coverage   55.96%   55.97%            
========================================
  Files        1024     1017     -7     
  Lines       99184    98426   -758     
========================================
- Hits        55512    55097   -415     
+ Misses      39423    39124   -299     
+ Partials     4249     4205    -44     
Flag Coverage Δ
unittests 55.97% <94.84%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue force-pushed the petera/refactor-access-connection-cache branch from e8b9b44 to b3cceeb Compare February 1, 2024 19:49
@peterargue peterargue force-pushed the petera/refactor-access-connection-cache branch from c34ab37 to 5b1060c Compare February 15, 2024 13:43
Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner! Cool!

@peterargue peterargue added this pull request to the merge queue Feb 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2024
@peterargue peterargue enabled auto-merge February 17, 2024 20:21
@peterargue peterargue added this pull request to the merge queue Feb 20, 2024
Merged via the queue into master with commit 2ff69ae Feb 20, 2024
50 of 51 checks passed
@peterargue peterargue deleted the petera/refactor-access-connection-cache branch February 20, 2024 21:55
peterargue added a commit that referenced this pull request Feb 22, 2024
…n-cache

[Access] Refactor access connection cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Improve client connection cache locking [Access] Fix race condition in connection cache
5 participants