-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Refactor access connection cache #5334
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5334 +/- ##
========================================
Coverage 55.96% 55.97%
========================================
Files 1024 1017 -7
Lines 99184 98426 -758
========================================
- Hits 55512 55097 -415
+ Misses 39423 39124 -299
+ Partials 4249 4205 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e8b9b44
to
b3cceeb
Compare
c34ab37
to
5b1060c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much cleaner! Cool!
…n-cache [Access] Refactor access connection cache
Closes: #5074
Closes: #5087
This PR addresses 2 issues related to Access connection caching by refactoring the
Cache
andCachedClient
structs to consolidate the cache creating and invalidation logic.