[Networking] Reverting 4978 #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kc1116
approved these changes
Jan 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5252 +/- ##
==========================================
+ Coverage 55.61% 56.45% +0.83%
==========================================
Files 995 86 -909
Lines 95485 7486 -87999
==========================================
- Hits 53107 4226 -48881
+ Misses 38403 2769 -35634
+ Partials 3975 491 -3484
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily reverts PR #4978 due to an architectural conflict with PR #5234.
While developing PR #4978, our goal was to refine peer scoring by individually counting errors. However, recent challenges in GossipSub revealed the need for an aggregated approach to manage inspection errors, setting thresholds as outlined in PR #5234. In consultation with @kc1116, we decided to revert PR #4978 and rework its architecture to align with the strategies introduced in PR #5234. Given the extensive nature of this redesign, reverting the current PR ensures architectural consistency in the
masterbranch.@yhassanzadeh13 will lead the redesign and refactoring efforts, detailed in this issue.
This reverts commit f60f782, reversing changes made to 7969310.