[Execution] Move maxCollectionHeight to metrics #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12bdb57 to
2113b21
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5244 +/- ##
==========================================
- Coverage 55.56% 49.03% -6.53%
==========================================
Files 995 177 -818
Lines 95383 15206 -80177
==========================================
- Hits 52997 7456 -45541
+ Misses 38405 7243 -31162
+ Partials 3981 507 -3474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
2113b21 to
64d592e
Compare
peterargue
reviewed
Jan 22, 2024
module/metrics/execution.go
Outdated
| @@ -950,7 +952,10 @@ func (ec *ExecutionCollector) RuntimeTransactionProgramsCacheHit() { | |||
| } | |||
|
|
|||
| func (ec *ExecutionCollector) UpdateCollectionMaxHeight(height uint64) { | |||
| ec.maxCollectionHeight.Set(float64(height)) | |||
| if height > ec.maxCollectionHeightData { | |||
There was a problem hiding this comment.
should this use a StrictMonotonousCounter?
64d592e to
d60cc1a
Compare
janezpodhostnik
approved these changes
Jan 23, 2024
engine/execution/ingestion/engine.go
Outdated
| @@ -683,11 +681,7 @@ func (e *Engine) addCollectionToMempool( | |||
| } | |||
|
|
|||
| // record collection max height metrics | |||
There was a problem hiding this comment.
comment might be redundant now, since the code already plainly states the same thing.
sideninja
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify ingestion engine by moving a metrics-related state var to metrics module.