[Util] Find block ID by state commitment #5240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Jan 13, 2024
| @@ -65,6 +66,7 @@ func addCommands() { | |||
| rootCmd.AddCommand(extract.Cmd) | |||
| rootCmd.AddCommand(export.Cmd) | |||
| rootCmd.AddCommand(checkpoint_list_tries.Cmd) | |||
| rootCmd.AddCommand(checkpoint_trie_stats.Cmd) | |||
There was a problem hiding this comment.
This adds the checkpoint trie stats to the util, which is useful to read the trie root hashes of a checkpoint file without reading the entire checkpoint file.
3b5e1e7 to
88a1928
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5240 +/- ##
==========================================
- Coverage 58.56% 55.56% -3.00%
==========================================
Files 899 995 +96
Lines 85536 95297 +9761
==========================================
+ Hits 50097 52955 +2858
- Misses 31743 38365 +6622
- Partials 3696 3977 +281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Jan 18, 2024
janezpodhostnik
approved these changes
Jan 18, 2024
8858b71 to
028ff6a
Compare
5f590aa to
6326600
Compare
Co-authored-by: Janez Podhostnik <67895329+janezpodhostnik@users.noreply.github.com>
6326600 to
f9bf295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command to util to find block ID by state commitment within a height range.
This is useful to know which block is the checkpoint for.
When recovering an execution node to an old state, we need to know which block is the checkpoint file for. The checkpoint file contains tries with state commitments as trie root hashes. However, the checkpoint file doesn't contain block information, it's difficult to know which blocks are the state commitments for. With this util command, we can specify a height range, and look up the block ID for a list of state commitments we read from the checkpoint file