Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Use local events in access APIs and index collections from exec data - backport #5195

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

[Access] Use local event for AccessAPI get events endpoints
…aming2

[Access] Use local event for event streaming API
…cdata

[Access] Index collections from execution data
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (c27cef0) 55.92% compared to head (4f05dcc) 55.99%.

Files Patch % Lines
engine/access/ingestion/engine.go 64.64% 27 Missing and 8 partials ⚠️
engine/access/rpc/backend/backend_events.go 69.23% 21 Missing and 7 partials ⚠️
engine/access/rpc/backend/config.go 28.57% 10 Missing ⚠️
...gine/access/state_stream/backend/backend_events.go 75.00% 8 Missing and 2 partials ⚠️
utils/unittest/fixtures.go 0.00% 3 Missing ⚠️
engine/access/rest/routes/test_helpers.go 87.50% 1 Missing ⚠️
engine/access/rpc/backend/backend_accounts.go 75.00% 1 Missing ⚠️
engine/access/rpc/backend/backend_scripts.go 75.00% 1 Missing ⚠️
module/metrics/execution_state_indexer.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.32    #5195      +/-   ##
==========================================
+ Coverage   55.92%   55.99%   +0.06%     
==========================================
  Files         946      946              
  Lines       89206    89368     +162     
==========================================
+ Hits        49891    50043     +152     
+ Misses      35598    35597       -1     
- Partials     3717     3728      +11     
Flag Coverage Δ
unittests 55.99% <72.04%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue merged commit 354396b into v0.32 Jan 19, 2024
54 checks passed
@peterargue peterargue deleted the petera/backport-events-streaming-v0.32 branch January 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants