Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storehouse] Add metrics for register store #5170

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

zhangchiqing
Copy link
Member

Close #5005

@zhangchiqing zhangchiqing requested review from peterargue and sideninja and removed request for ramtinms December 20, 2023 19:31
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (d0b0ef2) 56.44% compared to head (00d779e) 56.41%.
Report is 73 commits behind head on master.

Files Patch % Lines
module/metrics/execution.go 0.00% 9 Missing ⚠️
...ine/execution/storehouse/register_store_metrics.go 0.00% 6 Missing ⚠️
cmd/execution_builder.go 0.00% 5 Missing ⚠️
engine/execution/storehouse/register_store.go 37.50% 4 Missing and 1 partial ⚠️
module/metrics/noop.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5170      +/-   ##
==========================================
- Coverage   56.44%   56.41%   -0.03%     
==========================================
  Files         981      981              
  Lines       93112    92988     -124     
==========================================
- Hits        52557    52462      -95     
+ Misses      36666    36636      -30     
- Partials     3889     3890       +1     
Flag Coverage Δ
unittests 56.41% <10.34%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing added this pull request to the merge queue Dec 22, 2023
Merged via the queue into master with commit 0783c24 Dec 22, 2023
51 checks passed
@zhangchiqing zhangchiqing deleted the leo/register-store-metrics branch December 22, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storehouse] Add Metrics to key modules
4 participants