Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beyond EVM] performant StateDB implementation - part 4 #5169

Merged
merged 20 commits into from
Jan 6, 2024
Merged

[Beyond EVM] performant StateDB implementation - part 4 #5169

merged 20 commits into from
Jan 6, 2024

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Dec 19, 2023 •
edited
Loading

see #5129

@ramtinms ramtinms marked this pull request as ready for review December 20, 2023 19:43
@ramtinms ramtinms requested a review from sideninja December 20, 2023 19:43
janezpodhostnik
janezpodhostnik approved these changes Dec 28, 2023
View reviewed changes
fvm/evm/stdlib/contract.go Outdated Show resolved Hide resolved
m-Peter
m-Peter approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from ramtin/5129-new-evm-stateDB-part3 to master January 5, 2024 22:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6459232) 56.63% compared to head (c572fdf) 56.65%.

Files Patch % Lines
fvm/evm/emulator/state/delta.go 40.00% 2 Missing and 1 partial ⚠️
fvm/evm/emulator/emulator.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5169      +/-   ##
==========================================
+ Coverage   56.63%   56.65%   +0.01%     
==========================================
  Files         985      982       -3     
  Lines       94333    93877     -456     
==========================================
- Hits        53427    53186     -241     
+ Misses      36935    36744     -191     
+ Partials     3971     3947      -24
Flag Coverage Δ
unittests 56.65% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms enabled auto-merge January 6, 2024 03:13
@ramtinms ramtinms added this pull request to the merge queue Jan 6, 2024
Merged via the queue into master with commit f3bb713 Jan 6, 2024
51 checks passed
@ramtinms ramtinms deleted the ramtin/5129-new-evm-stateDB-part4 branch January 6, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideninja sideninja sideninja approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@m-Peter m-Peter m-Peter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ramtinms @codecov-commenter @m-Peter @janezpodhostnik @sideninja