[Storehouse] Fix dynamic bootstrapping for storehouse #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
commented
Dec 19, 2023
| @@ -801,12 +801,12 @@ func (exeNode *ExecutionNode) LoadRegisterStore( | |||
|
|
|||
| if !bootstrapped { | |||
| checkpointFile := path.Join(exeNode.exeConf.triedir, modelbootstrap.FilenameWALRootCheckpoint) | |||
| root, err := exeNode.builder.RootSnapshot.Head() | |||
| sealedRoot, err := node.State.Params().SealedRoot() | |||
There was a problem hiding this comment.
In dynamic bootstrapping, the sealed root is lower than finalized root (RootSnapshot.Head returns finalized root), EN needs to load [sealedRoot + 1, finalizedRoot] block range on startup.
It is now consistent with how the existing block loader works
Note, block below finalizedRoot can still be retrieved by height.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5165 +/- ##
=======================================
Coverage 56.49% 56.49%
=======================================
Files 979 979
Lines 93159 93175 +16
=======================================
+ Hits 52628 52640 +12
- Misses 36626 36634 +8
+ Partials 3905 3901 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ee17ecf to
2c55334
Compare
2c55334 to
4c6e1f1
Compare
peterargue
approved these changes
Dec 22, 2023
jordanschalm
approved these changes
Dec 22, 2023
7f9872a to
1db40c6
Compare
1db40c6 to
11e9567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5183
This PR fixes loading blocks on startup for storehouse when the node is dynamic bootstrapped