Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storehouse] Improve InMemoryRegisterStore's IsBlockExecuted method #5125

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

zhangchiqing
Copy link
Member

This PR optimize the IsBlockExecuted method.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6a6cd7c) 56.35% compared to head (7a11784) 59.22%.
Report is 64 commits behind head on master.

Files Patch % Lines
...e/execution/storehouse/in_memory_register_store.go 50.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5125      +/-   ##
==========================================
+ Coverage   56.35%   59.22%   +2.87%     
==========================================
  Files         977      418     -559     
  Lines       91770    40327   -51443     
==========================================
- Hits        51714    23883   -27831     
+ Misses      36221    14706   -21515     
+ Partials     3835     1738    -2097     
Flag Coverage Δ
unittests 59.22% <50.00%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing requested review from fxamacker, janezpodhostnik, sideninja and peterargue and removed request for ramtinms December 9, 2023 00:37
@zhangchiqing zhangchiqing force-pushed the leo/in-memory-store-pruned-height branch from fd954fc to f43dc91 Compare December 9, 2023 00:40
@zhangchiqing zhangchiqing force-pushed the leo/in-memory-store-pruned-height branch from f43dc91 to 7a11784 Compare December 11, 2023 20:42
@zhangchiqing zhangchiqing force-pushed the leo/in-memory-store-pruned-height branch from 7a11784 to 76ffa80 Compare December 11, 2023 20:50
@zhangchiqing zhangchiqing added this pull request to the merge queue Dec 11, 2023
Merged via the queue into master with commit 3048504 Dec 11, 2023
53 checks passed
@zhangchiqing zhangchiqing deleted the leo/in-memory-store-pruned-height branch December 11, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants