Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Flow crypto module import #5100

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Dec 1, 2023

#4358 introduced replace statements in the repo's go.mod files to facilitate the CI tests of the branch. The CI jobs and Docker files on the branch needed updates because of to the different build processes in flow-go with the old crypto module and the new one.

Once the new crypto module is merged, a new tag v0.25.0 will be introduced and the flow-go repo needs to clean up the crypto import:

  • remove the replace statements
  • use the new crypto module tag

@tarakby tarakby changed the base branch from feature/blst-based-crypto to master December 6, 2023 06:19
Tarak Ben Youssef added 2 commits December 6, 2023 00:55
@tarakby tarakby marked this pull request as ready for review December 6, 2023 06:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dffe11) 56.30% compared to head (dd977b4) 56.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5100   +/-   ##
=======================================
  Coverage   56.30%   56.30%           
=======================================
  Files         976      976           
  Lines       91740    91740           
=======================================
+ Hits        51651    51654    +3     
- Misses      36263    36266    +3     
+ Partials     3826     3820    -6     
Flag Coverage Δ
unittests 56.30% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarakby tarakby added this pull request to the merge queue Dec 6, 2023
Merged via the queue into master with commit 6cbb9d7 Dec 6, 2023
53 checks passed
@tarakby tarakby deleted the tarak/update-crypto-version branch December 6, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants