Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master with feature-flip-204 #5057

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 24, 2023

Clean merge besides go.mod files and state commitments. All conflicting changes will be overwritten by the core-contracts version bump in #5027.

Changes to conflicting files are captured in 677abf8.

This is needed to synchronize flow-go, core-contracts, and flow-emulator.

yhassanzadeh13 and others added 30 commits November 9, 2023 15:22
[CI][Testing] Add BuildJet CI runners for unit tests, integration tests; cache Docker images
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
…r-store

[Storehouse] Storehouse in memory regsiter store
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 438 lines in your changes are missing coverage. Please review.

Comparison is base (de721aa) 56.05% compared to head (0623b55) 55.78%.

Files Patch % Lines
module/metrics/execution.go 0.00% 71 Missing ⚠️
fvm/evm/stdlib/contract.go 82.70% 33 Missing and 27 partials ⚠️
network/p2p/test/fixtures.go 27.11% 43 Missing ⚠️
network/netconf/flags.go 0.00% 34 Missing ⚠️
network/p2p/p2pnode/gossipSubAdapter.go 41.86% 24 Missing and 1 partial ⚠️
fvm/bootstrap.go 17.39% 18 Missing and 1 partial ⚠️
module/metrics/unicast_manager.go 0.00% 16 Missing ⚠️
...validation/control_message_validation_inspector.go 83.13% 11 Missing and 3 partials ⚠️
network/p2p/scoring/internal/subscriptionCache.go 83.13% 11 Missing and 3 partials ⚠️
fvm/evm/evm.go 55.55% 8 Missing and 4 partials ⚠️
... and 26 more
Additional details and impacted files
@@                            Coverage Diff                             @@
##           feature/flip-204-epoch-target-end-time    #5057      +/-   ##
==========================================================================
- Coverage                                   56.05%   55.78%   -0.28%     
==========================================================================
  Files                                         964      955       -9     
  Lines                                       89705    88269    -1436     
==========================================================================
- Hits                                        50283    49237    -1046     
+ Misses                                      35658    35295     -363     
+ Partials                                     3764     3737      -27     
Flag Coverage Δ
unittests 55.78% <63.40%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is just to get tests to pass, all these changes will be overwritten
with the update to version v0.15.0 in #5027
@jordanschalm jordanschalm merged commit 64356c8 into feature/flip-204-epoch-target-end-time Nov 27, 2023
54 checks passed
@jordanschalm jordanschalm deleted the jordan/sync-feat-flip204-master branch November 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.