Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Cleanup script execution comparisons #4956

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

peterargue
Copy link
Contributor

Refactor the script execution comparison to make it simpler, and add tests.

@peterargue peterargue changed the title [Access] Improve script exec compare logging [Access] Cleanup script execution comparisons Nov 8, 2023
@peterargue peterargue self-assigned this Nov 8, 2023
Copy link
Contributor

@sideninja sideninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice refactor

Base automatically changed from petera/4798-improve-compare-logging to master November 8, 2023 18:20
@peterargue peterargue enabled auto-merge November 8, 2023 19:43
@peterargue peterargue added this pull request to the merge queue Nov 8, 2023
@peterargue peterargue removed this pull request from the merge queue due to a manual request Nov 8, 2023
@peterargue peterargue added this pull request to the merge queue Nov 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 9, 2023
@peterargue peterargue added this pull request to the merge queue Nov 9, 2023
Merged via the queue into master with commit 6f601e4 Nov 9, 2023
36 checks passed
@peterargue peterargue deleted the petera/4798-cleanup-compare-logic branch November 9, 2023 05:41
peterargue added a commit that referenced this pull request Nov 14, 2023
[Access] Cleanup script execution comparisons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants