Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 6.4 - Fix EVM contract tests #4941

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

turbolent
Copy link
Member

Depends on #4897

  • Use proper environment kind for transactions and scripts
  • Improve test for deposit function: deposit non-empty vault by minting tokens

@ramtinms ramtinms changed the title [FVM] Fix EVM contract tests [FVM] beyond EVM part 6.4 - Fix EVM contract tests Nov 7, 2023
Base automatically changed from bastian/evm-deploy to master November 15, 2023 00:53
@turbolent turbolent enabled auto-merge November 15, 2023 00:55
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac2fa03) 56.27% compared to head (7682f9c) 59.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4941      +/-   ##
==========================================
+ Coverage   56.27%   59.92%   +3.64%     
==========================================
  Files         969      618     -351     
  Lines       90410    57113   -33297     
==========================================
- Hits        50877    34223   -16654     
+ Misses      35744    20335   -15409     
+ Partials     3789     2555    -1234     
Flag Coverage Δ
unittests 59.92% <ø> (+3.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent added this pull request to the merge queue Nov 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2023
@turbolent turbolent added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit 43684b9 Nov 15, 2023
54 checks passed
@turbolent turbolent deleted the bastian/evm-fix-tests branch November 15, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants