Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Allow get blocks script calls #4894

Merged
merged 9 commits into from
Oct 30, 2023

Conversation

sideninja
Copy link
Contributor

Closes: #4880

Support calls for get blocks as part of the script execution.

@sideninja sideninja requested a review from koko1123 October 27, 2023 17:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bfe60bc) 55.85% compared to head (484f2a9) 54.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4894      +/-   ##
==========================================
- Coverage   55.85%   54.73%   -1.12%     
==========================================
  Files         945      626     -319     
  Lines       88164    56373   -31791     
==========================================
- Hits        49246    30858   -18388     
+ Misses      35206    23056   -12150     
+ Partials     3712     2459    -1253     
Flag Coverage Δ
unittests 54.73% <66.66%> (-1.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
module/execution/scripts.go 69.35% <100.00%> (+1.02%) ⬆️
module/state_synchronization/indexer/indexer.go 74.07% <0.00%> (+3.89%) ⬆️

... and 324 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sideninja sideninja closed this Oct 27, 2023
@sideninja sideninja reopened this Oct 27, 2023
@sideninja sideninja enabled auto-merge October 27, 2023 17:36
@sideninja sideninja added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@sideninja sideninja added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@sideninja sideninja added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@sideninja sideninja requested a review from peterargue as a code owner October 30, 2023 13:41
@sideninja sideninja enabled auto-merge October 30, 2023 14:09
@sideninja sideninja disabled auto-merge October 30, 2023 14:09
@sideninja sideninja enabled auto-merge October 30, 2023 15:46
@sideninja sideninja added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 30, 2023
@peterargue peterargue enabled auto-merge October 30, 2023 21:39
@peterargue peterargue added this pull request to the merge queue Oct 30, 2023
Merged via the queue into master with commit d86b4f4 Oct 30, 2023
36 checks passed
@peterargue peterargue deleted the gregor/script-execution/get-block-2 branch October 30, 2023 22:56
peterargue added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Script Execution] Add support for GetBlockAtHeight on Access nodes
5 participants