Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 6.2 - Implement EVM.BridgedAccount.withdraw #4890

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

turbolent
Copy link
Member

Depends on #4889

@ramtinms ramtinms changed the title [FVM] Implement EVM.BridgedAccount.withdraw [FVM] beyond EVM part 6.2 - Implement EVM.BridgedAccount.withdraw Oct 31, 2023
Base automatically changed from bastian/evm-deposit to master November 14, 2023 22:30
@turbolent
Copy link
Member Author

@ramtinms with master merged, TestBridgedAccountWithdraw fails with evm runtime error: account does not exist. Don't think that's caused by the PR itself. Any ideas?

@ramtinms
Copy link
Contributor

@turbolent probably missing the flag for bootstraping, let me take a look

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (75fa942) 56.22% compared to head (863357b) 56.22%.

Files Patch % Lines
fvm/evm/stdlib/contract.go 87.50% 3 Missing and 3 partials ⚠️
fvm/evm/handler/handler.go 50.00% 2 Missing ⚠️
fvm/evm/emulator/emulator.go 75.00% 1 Missing ⚠️
fvm/script.go 0.00% 1 Missing ⚠️
fvm/transactionInvoker.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4890   +/-   ##
=======================================
  Coverage   56.22%   56.22%           
=======================================
  Files         969      969           
  Lines       90306    90362   +56     
=======================================
+ Hits        50772    50805   +33     
- Misses      35757    35770   +13     
- Partials     3777     3787   +10     
Flag Coverage Δ
unittests 56.22% <81.35%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent added this pull request to the merge queue Nov 14, 2023
Merged via the queue into master with commit b05bb9c Nov 14, 2023
54 checks passed
@turbolent turbolent deleted the bastian/evm-withdraw branch November 14, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants