Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Protocol State] Sync master to feature/dynamic-protocol-state #4814

Conversation

durkmurder
Copy link
Member

Context

This PR syncs master to feature branch. No serious conflicts this time.
List of conflicted files which I manually merged:

  both modified:   engine/access/rpc/backend/backend.go
  both modified:   storage/all.go
  both modified:   utils/unittest/fixtures.go

Gregor Gololicic and others added 30 commits September 26, 2023 17:15
…che-panic

[Access] Fix panic condition in client connection cache
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: 464 lines in your changes are missing coverage. Please review.

Comparison is base (5b58dcf) 54.91% compared to head (ad57e46) 55.81%.
Report is 17 commits behind head on feature/dynamic-protocol-state.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           feature/dynamic-protocol-state    #4814      +/-   ##
==================================================================
+ Coverage                           54.91%   55.81%   +0.89%     
==================================================================
  Files                                 923      945      +22     
  Lines                               86129    87715    +1586     
==================================================================
+ Hits                                47302    48961    +1659     
+ Misses                              35221    35073     -148     
- Partials                             3606     3681      +75     
Flag Coverage Δ
unittests 55.81% <63.80%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...md/util/ledger/reporters/fungible_token_tracker.go 87.70% <100.00%> (+0.30%) ⬆️
engine/access/rest/routes/handler.go 77.41% <100.00%> (+13.97%) ⬆️
engine/access/rest/routes/router.go 88.88% <100.00%> (+3.88%) ⬆️
engine/access/rpc/backend/backend_transactions.go 54.36% <ø> (ø)
engine/access/rpc/connection/cache.go 96.07% <100.00%> (+0.52%) ⬆️
engine/access/rpc/connection/connection.go 57.14% <ø> (+2.75%) ⬆️
engine/access/rpc/connection/manager.go 83.01% <100.00%> (-1.17%) ⬇️
engine/access/rpc/connection/node_mock.go 100.00% <100.00%> (ø)
engine/access/state_stream/backend.go 93.40% <100.00%> (+0.38%) ⬆️
engine/access/state_stream/engine.go 0.00% <ø> (ø)
... and 107 more

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@durkmurder durkmurder changed the base branch from master to feature/dynamic-protocol-state October 13, 2023 13:01
Copy link
Member

@AlexHentschel AlexHentschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@durkmurder durkmurder merged commit 07c8e12 into feature/dynamic-protocol-state Oct 16, 2023
@durkmurder durkmurder deleted the yurii/sync-master-to-dynamic-protocol-state branch October 16, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.