-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Crypto] C code sanitization #4654
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarakby
force-pushed
the
tarak/blst-sanitize
branch
from
August 24, 2023 18:30
8aef3c6
to
bacdb33
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## feature/blst-based-crypto #4654 +/- ##
=============================================================
- Coverage 61.23% 53.70% -7.54%
=============================================================
Files 280 857 +577
Lines 28651 79948 +51297
=============================================================
+ Hits 17545 42937 +25392
- Misses 9653 33615 +23962
- Partials 1453 3396 +1943
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msan
(only works on Linux and with clang)asan
(only works on Linux)msan
) to a CI job and they are required to pass for new PRsmsan
has many false positive errors fromuse-of-unitialized-value
. These errors have been debugged one by one to make sure no uninitialized memory has been read.NO_MSAN
macro has been added during debugging to disablemsan
in functions. The macro was left in the code for future debugging. It is only defined when compiling with definedMSAN
(look at thec-msan
target in Makefile).Side changes:
./bls_src/README
with instructions of updating BLST version.Fr_is_zero
.DEBUG
macro .