-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ALSP] Synchronization Engine SyncRequest
spam detection (Permissionless-related engine level spam detection)
#4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4590 +/- ##
==========================================
- Coverage 54.71% 48.72% -6.00%
==========================================
Files 917 124 -793
Lines 85633 11534 -74099
==========================================
- Hits 46858 5620 -41238
+ Misses 35183 5589 -29594
+ Partials 3592 325 -3267
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…b.com/onflow/flow-go into misha/6812-alsp-engine-spam-detection
yhassanzadeh13
approved these changes
Aug 25, 2023
gomisha
requested review from
peterargue,
AlexHentschel,
durkmurder and
jordanschalm
as code owners
August 28, 2023 10:35
gomisha
changed the title
[Application Layer Spam Prevention] Synchronization Engine
[ALSP] Synchronization Engine Aug 28, 2023
SyncRequest
spam detection (Permissionless-related engine level spam detection)SyncRequest
spam detection (Permissionless-related engine level spam detection)
gomisha
removed request for
durkmurder,
jordanschalm,
AlexHentschel and
peterargue
August 28, 2023 10:41
kc1116
approved these changes
Aug 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ALSP spam level protection to the Synchronization Engine's
SyncRequest
message.This is the first PR to implement ALSP misbehavior reporting at the engine level.
TestLoad_Process_SyncRequest_HigherThanReceiver_OutsideTolerance_SometimesReportSpam
TestLoad_Process_SyncRequest_HigherThanReceiver_OutsideTolerance_AlwaysReportSpam
Process()
- these are all currently no-ops except forSyncRequest
SyncRequest
spam checking is hard coded to count a message as spam 1% of the time (i.e. approximately 1/100 messages); this will be updated in subsequent PRs to be configurable as a runtime flag when starting the engineFuture PRs will cover ALSP misbehavior reporting for other message types (e.g. RangeRequest, BatchRequest, SyncRequest, SyncResponse, BlockResponse)
ref: https://github.com/dapperlabs/flow-go/issues/6812