1898 slashing violations consumer alsp integration test #4549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4549 +/- ##
==========================================
- Coverage 56.25% 54.45% -1.81%
==========================================
Files 653 914 +261
Lines 64699 85282 +20583
==========================================
+ Hits 36396 46437 +10041
- Misses 25362 35255 +9893
- Partials 2941 3590 +649
Flags with carried forward coverage won't be shown. Click here to find out more.
|
yhassanzadeh13
approved these changes
Jul 11, 2023
Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
Co-authored-by: Yahya Hassanzadeh, Ph.D. <yhassanzadeh@ieee.org>
peterargue
approved these changes
Jul 18, 2023
| }() | ||
| } | ||
| } | ||
| unittest.RequireReturnsBefore(t, violationsWg.Wait, 100*time.Millisecond, "slashing violations not reported in time") |
There was a problem hiding this comment.
do the calls to report each violation need to be done async? This could introduce flakiness due to timeouts, while reporting the callbacks serially most likely wouldn't.
There was a problem hiding this comment.
This is done async so that we can ensure all async components under the hood are working as expected (queue, locks, workers etc). This will not cause flakiness as there are no network operations happening, it's just building up a queue of violations that will eventually be processed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an E2E functional test for the ALSP slashing violations consumer integration. The test ensures that the slashing violation consumer is reporting misbehaviors for slashable offenses as expected.