Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add grpc streaming metrics #4540

Merged
merged 2 commits into from
Jul 7, 2023
Merged

[Access] Add grpc streaming metrics #4540

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6c6e27
[Access] Add grpc streaming metrics
peterargue Jul 5, 2023
7b304d2
Merge branch 'master' into petera/add-streaming-metrics
peterargue Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions engine/access/state_stream/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,25 +97,31 @@ func NewEng(
grpc.MaxSendMsgSize(int(config.MaxExecutionDataMsgSize)),
}

var interceptors []grpc.UnaryServerInterceptor // ordered list of interceptors
// ordered list of interceptors
var unaryInterceptors []grpc.UnaryServerInterceptor

// if rpc metrics is enabled, add the grpc metrics interceptor as a server option
if config.RpcMetricsEnabled {
interceptors = append(interceptors, grpc_prometheus.UnaryServerInterceptor)
unaryInterceptors = append(unaryInterceptors, grpc_prometheus.UnaryServerInterceptor)

// note: intentionally not adding logging or rate limit interceptors for streams.
// rate limiting is done in the handler, and we don't need log events for every message as
// that would be too noisy.
grpcOpts = append(grpcOpts, grpc.StreamInterceptor(grpc_prometheus.StreamServerInterceptor))
}

if len(apiRatelimits) > 0 {
// create a rate limit interceptor
rateLimitInterceptor := rpc.NewRateLimiterInterceptor(log, apiRatelimits, apiBurstLimits).UnaryServerInterceptor
// append the rate limit interceptor to the list of interceptors
interceptors = append(interceptors, rateLimitInterceptor)
unaryInterceptors = append(unaryInterceptors, rateLimitInterceptor)
}

// add the logging interceptor, ensure it is innermost wrapper
interceptors = append(interceptors, rpc.LoggingInterceptor(log)...)
unaryInterceptors = append(unaryInterceptors, rpc.LoggingInterceptor(log)...)

// create a chained unary interceptor
chainedInterceptors := grpc.ChainUnaryInterceptor(interceptors...)
grpcOpts = append(grpcOpts, chainedInterceptors)
grpcOpts = append(grpcOpts, grpc.ChainUnaryInterceptor(unaryInterceptors...))

server := grpc.NewServer(grpcOpts...)

Expand Down