[Access] Update state stream API to return json-cdc encoded events #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.31 #4533 +/- ##
==========================================
+ Coverage 53.74% 53.80% +0.05%
==========================================
Files 893 893
Lines 84533 84577 +44
==========================================
+ Hits 45435 45506 +71
+ Misses 35572 35527 -45
- Partials 3526 3544 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zhangchiqing
approved these changes
Jun 29, 2023
koko1123
reviewed
Jun 29, 2023
Comment on lines
+731
to
+733
| func EventsToMessagesFromVersion(flowEvents []flow.Event, version execproto.EventEncodingVersion) ([]*entities.Event, error) { | ||
| events := make([]*entities.Event, len(flowEvents)) | ||
| for i, e := range flowEvents { |
There was a problem hiding this comment.
you won't need this after merging this: #4522 (review), right?
There was a problem hiding this comment.
we will, but I have a followup PR that will replace this. it's just taken longer than I had originally planned so I wanted to get this out sooner
| @@ -927,6 +957,21 @@ func MessageToChunk(m *entities.Chunk) (*flow.Chunk, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| // BlockExecutionDataEventPayloadsToJson converts all event payloads from CCF to JSON-CDC in place | |||
| // This is a temporary workaround until a more robust solution is implemented | |||
| func BlockExecutionDataEventPayloadsToJson(m *entities.BlockExecutionData) error { | |||
There was a problem hiding this comment.
To avoid copying the whole object. it's being done on the precomputed entity object so it won't affect the original objects
koko1123
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the State Stream API to return JSON-CDC encoded events like the rest of the AccessAPI.
A more robust change will be included on master that includes options to override the version for an individual AN