[CI] Update workflows to use setup-go@v4

[peterargue]

Update all workflows to use actions/setup-go@v4. This is the latest version and includes default dependency caching

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fef6b06) 56.27% compared to head (3fe1b30) 50.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4482      +/-   ##
==========================================
- Coverage   56.27%   50.55%   -5.72%     
==========================================
  Files         977      191     -786     
  Lines       91770    16519   -75251     
==========================================
- Hits        51644     8352   -43292     
+ Misses      36300     7582   -28718     
+ Partials     3826      585    -3241     

Flag	Coverage Δ
unittests	50.55% <ø> (-5.72%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 0188f21

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	5.75s ± 2%	5.83s ± 0%	+1.40%	(p=0.048 n=7+5)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	147ms ± 4%	151ms ± 3%	~	(p=0.093 n=6+6)
RuntimeTransaction/reference_tx-2	47.3ms ±26%	42.4ms ± 7%	~	(p=0.101 n=7+6)
RuntimeTransaction/convert_int_to_string-2	46.0ms ± 4%	45.4ms ± 6%	~	(p=0.383 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	48.7ms ± 3%	49.3ms ±22%	~	(p=0.234 n=6+7)
RuntimeTransaction/get_signer_address-2	44.7ms ± 2%	44.4ms ± 5%	~	(p=0.589 n=6+6)
RuntimeTransaction/get_public_account-2	47.3ms ± 5%	46.8ms ± 4%	~	(p=0.534 n=7+6)
RuntimeTransaction/get_account_and_get_balance-2	355ms ± 4%	352ms ± 2%	~	(p=0.234 n=7+6)
RuntimeTransaction/get_account_and_get_available_balance-2	351ms ± 5%	347ms ± 3%	~	(p=0.535 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	50.2ms ± 3%	50.1ms ± 6%	~	(p=0.620 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	312ms ± 3%	309ms ± 4%	~	(p=0.295 n=6+7)
RuntimeTransaction/get_signer_vault-2	54.2ms ± 5%	53.1ms ± 1%	~	(p=0.165 n=7+7)
RuntimeTransaction/transfer_tokens-2	257ms ± 2%	260ms ± 5%	~	(p=0.534 n=6+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	53.1ms ± 7%	53.3ms ± 2%	~	(p=0.628 n=7+6)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	104ms ± 3%	103ms ± 6%	~	(p=0.456 n=7+7)
RuntimeTransaction/create_new_account-2	1.04s ± 2%	1.05s ± 3%	~	(p=0.628 n=7+6)
RuntimeTransaction/call_empty_contract_function-2	48.2ms ± 4%	48.3ms ± 5%	~	(p=0.902 n=7+7)
RuntimeTransaction/emit_event-2	63.9ms ± 2%	62.9ms ± 6%	~	(p=0.534 n=6+7)
RuntimeTransaction/borrow_array_from_storage-2	178ms ± 2%	176ms ± 4%	~	(p=0.710 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	176ms ± 4%	177ms ± 6%	~	(p=0.731 n=6+7)
RuntimeTransaction/get_signer_receiver-2	68.8ms ± 2%	66.9ms ± 3%	−2.88%	(p=0.017 n=7+7)
	alloc/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	53.4MB ± 5%	56.1MB ± 3%	+4.95%	(p=0.007 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	1.23GB ± 0%	1.24GB ± 1%	+0.92%	(p=0.004 n=5+6)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	36.2MB ± 6%	35.6MB ± 2%	~	(p=0.259 n=7+7)
RuntimeTransaction/convert_int_to_string-2	36.4MB ± 4%	36.7MB ± 4%	~	(p=0.456 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	36.4MB ± 3%	37.1MB ± 5%	~	(p=0.318 n=7+7)
RuntimeTransaction/get_signer_address-2	36.5MB ± 3%	36.1MB ± 3%	~	(p=0.318 n=7+7)
RuntimeTransaction/get_public_account-2	37.8MB ± 2%	37.5MB ± 4%	~	(p=0.628 n=6+7)
RuntimeTransaction/get_account_and_get_balance-2	123MB ± 3%	123MB ± 3%	~	(p=0.902 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	109MB ± 3%	110MB ± 3%	~	(p=0.383 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	37.5MB ± 3%	38.0MB ± 4%	~	(p=0.318 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	105MB ± 3%	105MB ± 3%	~	(p=0.456 n=7+7)
RuntimeTransaction/get_signer_vault-2	38.0MB ± 1%	37.5MB ± 4%	~	(p=0.432 n=5+7)
RuntimeTransaction/get_signer_receiver-2	41.8MB ± 6%	42.2MB ± 3%	~	(p=0.620 n=7+7)
RuntimeTransaction/transfer_tokens-2	80.6MB ± 3%	82.7MB ± 3%	~	(p=0.097 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	37.6MB ± 4%	38.2MB ± 3%	~	(p=0.456 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	54.4MB ± 6%	54.3MB ± 3%	~	(p=0.620 n=7+7)
RuntimeTransaction/create_new_account-2	183MB ± 1%	185MB ± 2%	~	(p=0.128 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	37.4MB ± 5%	37.4MB ± 4%	~	(p=0.902 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	71.4MB ± 3%	71.0MB ± 4%	~	(p=0.902 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	83.6MB ± 3%	82.3MB ± 5%	~	(p=0.383 n=7+7)
RuntimeTransaction/emit_event-2	42.4MB ± 4%	41.0MB ± 2%	−3.18%	(p=0.038 n=7+7)
	allocs/op		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2	279k ± 0%	278k ± 1%	~	(p=0.620 n=7+7)
RuntimeTransaction/reference_tx-2	91.6k ± 0%	91.6k ± 0%	~	(p=0.778 n=7+7)
RuntimeTransaction/convert_int_to_string-2	104k ± 0%	104k ± 0%	~	(p=0.376 n=7+6)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	115k ± 0%	115k ± 0%	~	(p=0.515 n=7+5)
RuntimeTransaction/get_signer_address-2	95.8k ± 0%	95.8k ± 0%	~	(p=0.776 n=7+7)
RuntimeTransaction/get_public_account-2	120k ± 0%	120k ± 0%	~	(p=0.647 n=6+7)
RuntimeTransaction/get_account_and_get_balance-2	1.33M ± 0%	1.33M ± 0%	~	(p=0.620 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2	1.29M ± 0%	1.29M ± 0%	~	(p=0.456 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2	131k ± 0%	131k ± 0%	~	(p=0.333 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.16M ± 0%	1.16M ± 0%	~	(p=0.295 n=7+6)
RuntimeTransaction/get_signer_vault-2	136k ± 0%	136k ± 0%	~	(p=0.874 n=7+7)
RuntimeTransaction/get_signer_receiver-2	223k ± 0%	223k ± 0%	~	(p=0.973 n=7+7)
RuntimeTransaction/transfer_tokens-2	861k ± 0%	861k ± 0%	~	(p=0.620 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	143k ± 0%	143k ± 0%	~	(p=0.308 n=7+5)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	225k ± 0%	225k ± 0%	~	(p=1.000 n=7+7)
RuntimeTransaction/create_new_account-2	2.36M ± 0%	2.36M ± 0%	~	(p=0.710 n=7+7)
RuntimeTransaction/call_empty_contract_function-2	109k ± 0%	109k ± 0%	~	(p=1.000 n=7+7)
RuntimeTransaction/emit_event-2	151k ± 0%	151k ± 0%	~	(p=0.103 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2	371k ± 0%	371k ± 0%	~	(p=0.400 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	304k ± 0%	304k ± 0%	~	(p=0.900 n=6+6)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	17.7M ± 0%	17.7M ± 0%	~	(p=0.805 n=7+7)
	computation		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	502 ± 0%	502 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	302 ± 0%	302 ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	1.00k ± 0%	1.00k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	3.10k ± 0%	3.10k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	1.70k ± 0%	1.70k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	3.50k ± 0%	3.50k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	202 ± 0%	202 ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	402 ± 0%	402 ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	602 ± 0%	602 ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
RuntimeTransaction/copy_array_from_storage-2	2.60k ± 0%	2.60k ± 0%	~	(all equal)
	interactions		delta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_address-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_public_account-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_balance-2	46.4k ± 0%	46.4k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_available_balance-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_vault-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/get_signer_receiver-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/transfer_tokens-2	38.1k ± 0%	38.1k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2	38.3k ± 0%	38.3k ± 0%	~	(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2	42.1k ± 0%	42.1k ± 0%	~	(all equal)
RuntimeTransaction/create_new_account-2	84.3k ± 0%	84.3k ± 0%	~	(all equal)
RuntimeTransaction/call_empty_contract_function-2	38.3k ± 0%	38.3k ± 0%	~	(all equal)
RuntimeTransaction/emit_event-2	38.3k ± 0%	38.3k ± 0%	~	(all equal)
RuntimeTransaction/borrow_array_from_storage-2	43.4k ± 0%	43.4k ± 0%	~	(p=0.192 n=7+7)
RuntimeTransaction/copy_array_from_storage-2	43.4k ± 0%	43.4k ± 0%	~	(all equal)
	us/tx		delta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-2	2.81k ± 2%	2.85k ± 0%	+1.40%	(p=0.045 n=7+5)

[gomisha]

LGTM. Added update in Makefile to fix verify-mocks intermittent failure in CI.