Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crypto] unplug relic from the crypto package and the rest of flow-go #4380

Merged
merged 12 commits into from
May 29, 2023

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented May 25, 2023

Remove everything related to Relic in both the flow-go/crypto package and the rest of the flow-go repo:

  • Flow crypto package:
    • merge relic and non-relic Go files and remove all relic tags.
    • remove Relic binary build scripts
    • remove Relic binary linking in cgo
    • update Makefile file
    • update README

-flow-go broader repo:

  • remove all relic tags.
  • update ci/Makefile/Docker by removing the Relic build step
  • update README

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:feature/blst-based-crypto commit c94b091

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #4380 (33c5e0e) into feature/blst-based-crypto (c94b091) will decrease coverage by 6.92%.
The diff coverage is 100.00%.

@@                      Coverage Diff                      @@
##           feature/blst-based-crypto    #4380      +/-   ##
=============================================================
- Coverage                      60.62%   53.71%   -6.92%     
=============================================================
  Files                            246      857     +611     
  Lines                          22804    79948   +57144     
=============================================================
+ Hits                           13826    42943   +29117     
- Misses                          7990    33607   +25617     
- Partials                         988     3398    +2410     
Flag Coverage Δ
unittests 53.71% <100.00%> (-6.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/bootstrap/cmd/genconfig.go 27.45% <ø> (ø)
...nsus/hotstuff/verification/combined_verifier_v2.go 52.56% <ø> (ø)
...nsus/hotstuff/verification/combined_verifier_v3.go 54.91% <ø> (ø)
...onsensus/hotstuff/verification/staking_verifier.go 68.96% <ø> (ø)
module/signature/aggregation.go 89.79% <ø> (ø)
...execution/computation/computer/result_collector.go 84.54% <100.00%> (ø)

... and 612 files with indirect coverage changes

@tarakby tarakby changed the title WIP [Crypto] unplug relic [Crypto] unplug relic from the crypto package and the test of flow-go May 25, 2023
@tarakby tarakby marked this pull request as ready for review May 25, 2023 23:32
@tarakby tarakby changed the title [Crypto] unplug relic from the crypto package and the test of flow-go [Crypto] unplug relic from the crypto package and the rest of flow-go May 26, 2023
@tarakby tarakby merged commit efefb51 into feature/blst-based-crypto May 29, 2023
@tarakby tarakby deleted the tarak/blst-unplug-relic branch May 29, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants