Skip to content

Commit

Permalink
cleaning and typos
Browse files Browse the repository at this point in the history
  • Loading branch information
Tarak Ben Youssef committed Oct 20, 2023
1 parent 6c34ae3 commit b180269
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 21 deletions.
5 changes: 0 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ cmd/util/util:
update-core-contracts-version:
./scripts/update-core-contracts.sh $(CC_VERSION)

############################################################################################
# CAUTION: DO NOT MODIFY THESE TARGETS! DOING SO WILL BREAK THE FLAKY TEST MONITOR

.PHONY: unittest-main
unittest-main:
# test all packages
Expand All @@ -84,8 +81,6 @@ install-tools: check-go-version install-mock-generators
verify-mocks: tidy generate-mocks
git diff --exit-code

############################################################################################

.SILENT: go-math-rand-check
go-math-rand-check:
# check that the insecure math/rand Go package isn't used by production code.
Expand Down
11 changes: 3 additions & 8 deletions crypto/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ else
ADX_SUPPORT := 1
endif

# the crypto package uses BLST source files underneath which may use ADX insructions.
# the crypto package uses BLST source files underneath which may use ADX instructions.
ifeq ($(ADX_SUPPORT), 1)
# if ADX insructions are supported, default is to use a fast ADX BLST implementation
# if ADX instructions are supported, default is to use a fast ADX BLST implementation
CRYPTO_FLAG := ""
else
# if ADX insructions aren't supported, this CGO flags uses a slower non-ADX BLST implementation
# if ADX instructions aren't supported, this CGO flags uses a slower non-ADX BLST implementation
CRYPTO_FLAG := "-O -D__BLST_PORTABLE__"
endif
CGO_FLAG := CGO_CFLAGS=$(CRYPTO_FLAG)
Expand Down Expand Up @@ -75,8 +75,6 @@ c-sanitize: c-asan
# - address sanitization and other checks (only on linux)
# - memory sanitization (target m-san) is disabled because of multiple false positives



# Go tidy
.PHONY: go-tidy
go-tidy:
Expand All @@ -90,9 +88,6 @@ lint: go-tidy
# revive -config revive.toml
golangci-lint run -v ./...




# test all packages
.PHONY: test
test:
Expand Down
6 changes: 3 additions & 3 deletions crypto_adx_flag.mk
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ else
ADX_SUPPORT := 1
endif

# the crypto package uses BLST source files underneath which may use ADX insructions.
# the crypto package uses BLST source files underneath which may use ADX instructions.
ifeq ($(ADX_SUPPORT), 1)
# if ADX insructions are supported, default is to use a fast ADX BLST implementation
# if ADX instructions are supported, default is to use a fast ADX BLST implementation
CRYPTO_FLAG := ""
else
# if ADX insructions aren't supported, this CGO flags uses a slower non-ADX BLST implementation
# if ADX instructions aren't supported, this CGO flags uses a slower non-ADX BLST implementation
CRYPTO_FLAG := "-O -D__BLST_PORTABLE__"
endif
6 changes: 1 addition & 5 deletions integration/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ integration-test: access-tests ghost-tests mvp-tests execution-tests verificatio
.PHONY: ci-integration-test
ci-integration-test: access-tests ghost-tests mvp-tests epochs-cohort1-tests epochs-cohort2-tests consensus-tests execution-tests verification-tests upgrades-tests network-tests collection-tests

############################################################################################
# CAUTION: DO NOT MODIFY THE TARGETS BELOW! DOING SO WILL BREAK THE FLAKY TEST MONITOR
# In particular, do not skip tests by commenting them out here.

# Run unit tests for test utilities in this module
.PHONY: test
test:
Expand Down Expand Up @@ -88,4 +84,4 @@ bft-gossipsub-tests:

.PHONY: bft-tests
bft-tests: bft-framework-tests bft-protocol-tests bft-gossipsub-tests
############################################################################################

0 comments on commit b180269

Please sign in to comment.