Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom VM] Improve and test instruction printer #3706

Merged

Conversation

turbolent
Copy link
Member

Description

  • Use a bytes.Reader to avoid manual index calculations
  • Return helpful errors
  • Add tests

Eventually we can maybe generate the decoding and printing (as well as encoding) from a specification (e.g. Go code), similar to how it was done for the WebAssembly instructions in https://github.com/onflow/cadence/pull/3705/files#diff-82ca63eac37e62fe45b1499cde54ac1e090fd495ba7ef9716d03708d656daa8dL484


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz November 29, 2024 19:59
@turbolent turbolent requested a review from SupunS as a code owner November 29, 2024 19:59
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@turbolent turbolent merged commit 83f76f6 into supun/vm-cadence-1.0 Nov 30, 2024
@turbolent turbolent deleted the bastian/improve-and-test-instruction-printer branch November 30, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants