[Custom VM] Improve and test instruction printer #3706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bytes.Reader
to avoid manual index calculationsEventually we can maybe generate the decoding and printing (as well as encoding) from a specification (e.g. Go code), similar to how it was done for the WebAssembly instructions in https://github.com/onflow/cadence/pull/3705/files#diff-82ca63eac37e62fe45b1499cde54ac1e090fd495ba7ef9716d03708d656daa8dL484
master
branchFiles changed
in the Github PR explorer