Allow injection of functions into composite values, refactor PublicKey based on it #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
commented
Oct 18, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit c00aedc Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2878 +/- ##
=======================================
Coverage 79.42% 79.42%
=======================================
Files 334 334
Lines 79027 79049 +22
=======================================
+ Hits 62768 62788 +20
- Misses 13950 13952 +2
Partials 2309 2309
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
6 tasks
dsainati1
approved these changes
Oct 19, 2023
SupunS
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2874
Description
The host might want composite values of certain types to have native functions. Add a function
SetCompositeValueFunctionsHandlerto the environment which allows that.Extend the
CompositeValue.GetMemberimplementation, from only linking in interpreted functions, to also querying a handler set in the interpreter configuration.As the built-in
PublicKeytype has native functions (e.g.verify) and is already implemented as aCompositeValue, refactor its existing implementation from injecting the native functions at construction time, to using the new injection mechanism added in this PR.This essentially allows making the
PublicKeytype storable (in a follow-up PR), because the native functions get linked in even after a public key value got loaded from storage.PublicKeyvalues are not yet storable exactly because of this missing function injection feature.masterbranchFiles changedin the Github PR explorer