Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#11): add default message for days without birthdays #14

Merged

Conversation

totegsito
Copy link
Contributor

This PR fixes #11.

Main changes

This PR creates a default message for when it is nobody's birthday, so there is always something to celebrate.

Notes

Message appearance has been tested using Slack Block Kit Builder.

Betisman
Betisman previously approved these changes Feb 13, 2023
Copy link

@Betisman Betisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what we want to send, ok for me.

Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@totegsito , I left a comment to know your opinion.

Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@inigomarquinez inigomarquinez merged commit 7c8d169 into onebeyond:main Feb 15, 2023
@totegsito totegsito deleted the feat/11-empty-non-celebrate-message branch February 16, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty let's celebrate message
3 participants