Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UR_DEVICE_INFO_BFLOAT16 #2702

Closed
wants to merge 1 commit into from
Closed

Remove UR_DEVICE_INFO_BFLOAT16 #2702

wants to merge 1 commit into from

Conversation

isaacault
Copy link
Contributor

Resolves #2385

@github-actions github-actions bot added conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues native-cpu Native CPU adapter specific issues labels Feb 13, 2025
@isaacault isaacault marked this pull request as ready for review February 13, 2025 06:01
@isaacault isaacault requested review from a team as code owners February 13, 2025 06:01
@isaacault isaacault requested a review from ldrumm February 13, 2025 06:01
aarongreig
aarongreig reviewed Feb 13, 2025
View reviewed changes
include/ur_api.h
/// [uint32_t] Returns 1 if the device doesn't have a notion of a
/// queue index. Otherwise, returns the number of queue indices that are
/// available for this device.
UR_DEVICE_INFO_MAX_COMPUTE_QUEUE_INDICES = 105,
UR_DEVICE_INFO_MAX_COMPUTE_QUEUE_INDICES = 104,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm I didn't consider that this would result in all the subsequent enum values changing, maybe we need a way to tag an enum as deprecated rather than removing it

npmiller
npmiller approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA/HIP changes LGTM

@isaacault isaacault mentioned this pull request Feb 19, 2025
Draft
@isaacault
Copy link
Contributor Author

Closing this after repo move. Continuing with intel/llvm#17053.

@isaacault isaacault closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig left review comments

@hvdijk hvdijk hvdijk approved these changes

@npmiller npmiller npmiller approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove UR_DEVICE_INFO_BFLOAT16
4 participants
@isaacault @hvdijk @npmiller @aarongreig