Improvements to align CTS and Spec for Event. #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isaacault
commented
Feb 10, 2025
- Added test case for urEventGetProfilingInfo return UR_RESULT_ERROR_PROFILING_INFO_NOT_AVAILABLE
- Added test case for urEventCreateWithNativeHandle return UR_RESULT_ERROR_INVALID_NULL_HANDLE
- Added test case for urEventCreateWithNativeHandle return UR_RESULT_ERROR_INVALID_NULL_POINTER
- Added test case for urEventSetCallback return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION
* Added test case for urEventGetProfilingInfo return UR_RESULT_ERROR_PROFILING_INFO_NOT_AVAILABLE * Added test case for urEventCreateWithNativeHandle return UR_RESULT_ERROR_INVALID_NULL_HANDLE * Added test case for urEventCreateWithNativeHandle return UR_RESULT_ERROR_INVALID_NULL_POINTER * Added test case for urEventSetCallback return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION
aarongreig
approved these changes
Feb 11, 2025
| UUR_ASSERT_SUCCESS_OR_UNSUPPORTED( | ||
| urEventGetNativeHandle(event, &native_event)); | ||
|
|
||
| // We cannot assume anything about a native_handle, not even if it's |
There was a problem hiding this comment.
can skip this comment for the negative tests, we aren't doing any further validation after checking the return code
* Remove native_handle comment on negative tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.