Make profiling info optional and update tests #2533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e866d27 to
f7b33d3
Compare
martygrant
approved these changes
Jan 9, 2025
aarongreig
reviewed
Jan 9, 2025
aarongreig
approved these changes
Jan 10, 2025
4b9b724 to
82f65c3
Compare
|
@oneapi-src/unified-runtime-native-cpu-write @oneapi-src/unified-runtime-hip-write @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-level-zero-write Can I get some quick eyeballs on this? It updates the profiling info call to return |
82f65c3 to
56bc47d
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 22, 2025
|
@oneapi-src/unified-runtime-native-cpu-write @oneapi-src/unified-runtime-hip-write @oneapi-src/unified-runtime-cuda-write @oneapi-src/unified-runtime-level-zero-write Can I get this looked at? |
56bc47d to
431e7dc
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 28, 2025
|
@oneapi-src/unified-runtime-native-cpu-write @oneapi-src/unified-runtime-level-zero-write Anything blocking this? |
431e7dc to
e5aa217
Compare
|
@oneapi-src/unified-runtime-native-cpu-write @oneapi-src/unified-runtime-level-zero-write Can I get this looked at? |
e5aa217 to
410dccb
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Feb 17, 2025
hvdijk
approved these changes
Feb 17, 2025
pbalcer
approved these changes
Feb 17, 2025
This patch turns all of the values returned by urEventGetProfilingInfo to be optional and updates adapters to handle this by returning the appropriate enum when it is not supported. The tests have also been updated, to ensure that returning a counter of "0" or values equal to the previous profiling event is no longer considered a failure.
410dccb to
29c83fd
Compare
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 20, 2025
…ional and improve its conformance test (#17067) Migrated from oneapi-src/unified-runtime#2533 This patch turns all of the values returned by urEventGetProfilingInfo to be optional and updates adapters to handle this by returning the appropriate enum when it is not supported. The tests have also been updated, to ensure that returning a counter of "0" or values equal to the previous profiling event is no longer considered a failure.
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Feb 21, 2025
… and improve its conformance test (#17067) Migrated from oneapi-src#2533 This patch turns all of the values returned by urEventGetProfilingInfo to be optional and updates adapters to handle this by returning the appropriate enum when it is not supported. The tests have also been updated, to ensure that returning a counter of "0" or values equal to the previous profiling event is no longer considered a failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch turns all of the values returned by urEventGetProfilingInfo
to be optional and updates adapters to handle this by returning the
appropriate enum when it is not supported.
The tests have also been updated, to ensure that returning a counter of
"0" or values equal to the previous profiling event is no longer
considered a failure.