Wrap urEventSetCallback when ran through loader #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
898c382 to
55425b3
Compare
RossBrunton
commented
Jan 9, 2025
| // Replace the callback with a wrapper function that gives the callback the loader event rather than a | ||
| // backend-specific event | ||
| auto wrapper_data = | ||
| new event_callback_wrapper_data_t{pfnNotify, hEvent, pUserData}; |
There was a problem hiding this comment.
Yes, I know. Manual memory management.
But I'm not sure if there's a better C++-y way of doing this, does anyone have any ideas?
There was a problem hiding this comment.
is it possible to use a smart pointer instead maybe?
There was a problem hiding this comment.
I don't think so. It needs to survive a roundtrip to and from a bare pointer to be used in the API.
There was a problem hiding this comment.
yeah, i don't think we can rely on raii here, unless you'd like to manually play around with constructing/destroying unique pointers, but I don't see much point.
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 9, 2025
This was referenced Jan 9, 2025
55425b3 to
a14e712
Compare
The events returned by the loader do not match the events returned by openCL (or other backends), which causes issues when adding a callback handler. This adds an intermediate wrapper to replace the event with the loader event.
a14e712 to
599a28e
Compare
pbalcer
approved these changes
Jan 14, 2025
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 14, 2025
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jan 14, 2025
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events returned by the loader do not match the events returned by
openCL (or other backends), which causes issues when adding a callback
handler. This adds an intermediate wrapper to replace the event with the
loader event.