Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeviceMSAN] Fix "urEnqueueUSM" APIs #2513

Merged
merged 16 commits into from
Jan 6, 2025

Conversation

AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Jan 2, 2025

LLVM: intel/llvm#16511

Intercept the following APIs for shadow propagation:

  • urEnqueueUSMFill
  • urEnqueueUSMMemcpy
  • urEnqueueUSMFill2D
  • urEnqueueUSMMemcpy2D

@AllanZyne AllanZyne requested a review from a team as a code owner January 2, 2025 14:16
@github-actions github-actions bot added the loader Loader related feature/bug label Jan 2, 2025
@AllanZyne AllanZyne changed the title [DeviceMSAN] Fix urEnqueueUSMXXXX APIs [DeviceMSAN] Fix "urEnqueueUSM" APIs Jan 2, 2025
Copy link
Contributor

@yingcong-wu yingcong-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @zhaomaosu should have a decisive review.
Also, please write a good description of this PR instead of an empty one.

@zhaomaosu
Copy link
Contributor

Suggest to add some sycl-in-tree e2e tests.

@AllanZyne
Copy link
Contributor Author

Suggest to add some sycl-in-tree e2e tests.

Added to syclos

@AllanZyne
Copy link
Contributor Author

Hi @oneapi-src/unified-runtime-maintain, please add this into 2025.1

Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kbenzie kbenzie added the v0.11.x Include in the v0.11.x release label Jan 6, 2025
@kbenzie kbenzie merged commit 533ab9b into oneapi-src:main Jan 6, 2025
73 checks passed
sarnex pushed a commit to intel/llvm that referenced this pull request Jan 6, 2025
UR: oneapi-src/unified-runtime#2513

Support USM related memory operations like "memset" and "memcpy"

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
@AllanZyne AllanZyne deleted the review/yang/fix_msan_usm branch January 7, 2025 02:18
kbenzie added a commit that referenced this pull request Jan 7, 2025
kbenzie added a commit that referenced this pull request Jan 7, 2025
kbenzie added a commit that referenced this pull request Jan 8, 2025
kbenzie added a commit that referenced this pull request Jan 8, 2025
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 19, 2025
UR: oneapi-src/unified-runtime#2513

Support USM related memory operations like "memset" and "memcpy"

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 25, 2025
UR: oneapi-src/unified-runtime#2513

Support USM related memory operations like "memset" and "memcpy"

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loader Loader related feature/bug v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants