-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L0] Fix external semaphore import function calls to match the header #2467
Merged
kbenzie
merged 1 commit into
oneapi-src:main
from
nrspruit:fix_external_import_function_call
Dec 16, 2024
Merged
[L0] Fix external semaphore import function calls to match the header #2467
kbenzie
merged 1 commit into
oneapi-src:main
from
nrspruit:fix_external_import_function_call
Dec 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Dec 13, 2024
•
edited
Loading
edited
- Fix the function pointer for the external semaphore import function calls to match the updated header.
nrspruit
force-pushed
the
fix_external_import_function_call
branch
from
December 13, 2024 19:38
cb57571
to
65933ee
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 13, 2024
-pre-commit PR for oneapi-src/unified-runtime#2467 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
- Fix the function pointers for the external semaphore import function calls to match the updated header. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
fix_external_import_function_call
branch
from
December 13, 2024 19:53
65933ee
to
be27d8f
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 13, 2024
-pre-commit PR for oneapi-src/unified-runtime#2467 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
changed the title
[L0] Fix external semaphore import function call to match the header
[L0] Fix external semaphore import function calls to match the header
Dec 13, 2024
aravindksg
approved these changes
Dec 13, 2024
raiyanla
approved these changes
Dec 13, 2024
@oneapi-src/unified-runtime-bindless-images-write , please approve since this fixes mistake due to errors in the extensions documentation in the driver. The docs have been fixed alongside the fix in the adapter. |
przemektmalon
approved these changes
Dec 16, 2024
kbenzie
added a commit
that referenced
this pull request
Dec 16, 2024
[L0] Fix external semaphore import function calls to match the header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
images
UR images
level-zero
L0 adapter specific issues
ready to merge
Added to PR's which are ready to merge
v0.11.x
Include in the v0.11.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.