Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command_buffer coverity issues #2379

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Nov 25, 2024

  • Change command handle constructors to accept const ref for vector types
  • Add std::move to certain vector assignments
  • Add missing call to store command handle in command buffer in urCommandBufferAppendMemBufferCopyExp

DPC++ PR intel/llvm#16215

@Bensuo Bensuo requested a review from a team as a code owner November 25, 2024 17:34
@github-actions github-actions bot added cuda CUDA adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Nov 25, 2024
@EwanC EwanC added the v0.11.x Include in the v0.11.x release label Nov 26, 2024
@EwanC EwanC added the ready to merge Added to PR's which are ready to merge label Nov 28, 2024
@Bensuo Bensuo force-pushed the ben/coverity-fixes branch from 8cc20ff to af7f49c Compare November 28, 2024 15:40
EwanC added a commit to reble/llvm that referenced this pull request Nov 29, 2024
Bump the UR tag to include coverity fixes
for command-buffers oneapi-src/unified-runtime#2379
@Bensuo Bensuo force-pushed the ben/coverity-fixes branch 4 times, most recently from dcb4465 to 52909c5 Compare December 4, 2024 13:00
- Change command handle constructors to accept const ref for vector types
- Add std::move to certain vector assignments
- Add missing call to store command handle in command buffer in urCommandBufferAppendMemBufferCopyExp
@Bensuo Bensuo force-pushed the ben/coverity-fixes branch from 52909c5 to 323b37c Compare December 5, 2024 12:07
@martygrant martygrant merged commit e37f75f into oneapi-src:main Dec 6, 2024
73 checks passed
martygrant added a commit to reble/llvm that referenced this pull request Dec 6, 2024
sommerlukas pushed a commit to intel/llvm that referenced this pull request Dec 9, 2024
Bump the UR tag to include coverity fixes for command-buffers
oneapi-src/unified-runtime#2379

---------

Co-authored-by: Martin Morrison-Grant <martin.morrisongrant@codeplay.com>
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 19, 2025
Bump the UR tag to include coverity fixes for command-buffers
oneapi-src/unified-runtime#2379

---------

Co-authored-by: Martin Morrison-Grant <martin.morrisongrant@codeplay.com>
KornevNikita pushed a commit to intel/llvm that referenced this pull request Feb 25, 2025
Bump the UR tag to include coverity fixes for command-buffers
oneapi-src/unified-runtime#2379

---------

Co-authored-by: Martin Morrison-Grant <martin.morrisongrant@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification cuda CUDA adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants